Support dynamic asyncapi specs as sql changes #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfallows
requested changes
Jan 27, 2025
Comment on lines
62
to
64
|
|
||
|
|
||
|
|
| import org.springframework.context.annotation.Configuration; | ||
|
|
||
| @Configuration | ||
| @ConfigurationProperties(prefix = "app.gen") |
There was a problem hiding this comment.
Is this intended to be api.gen?
There was a problem hiding this comment.
I guess you are saying whether we need a prefix at all?
| petstore_customers-stream-identity: | ||
| address: "/petstore_customers-stream-identity" | ||
| messages: | ||
| PETSTORE_CUSTOMERSMessage: |
There was a problem hiding this comment.
Suggested change
| PETSTORE_CUSTOMERSMessage: | |
| PetstoreCustomersMessage: |
Let's make the spec more readable, by converting PETSTORE_CUSTOMERS to PetstoreCustomers for example.
| protocol: http | ||
| channels: | ||
| petstore_customers-stream-identity: | ||
| address: "/petstore_customers-stream-identity" |
There was a problem hiding this comment.
We need to review the generated API paths for HTTP spec to make sure they are as natural as possible.
jfallows
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support dynamic asyncapi specs as sql changes.
Fixes #126