-
Notifications
You must be signed in to change notification settings - Fork 16
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
guard against empty rendered manifests
Signed-off-by: Kent <[email protected]>
- Loading branch information
Showing
8 changed files
with
323 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,244 @@ | ||
| package bookkeeper | ||
|
|
||
| import ( | ||
| "context" | ||
| "testing" | ||
|
|
||
| "github.com/pkg/errors" | ||
| "github.com/sirupsen/logrus" | ||
| "github.com/stretchr/testify/require" | ||
|
|
||
| "github.com/akuity/bookkeeper/internal/helm" | ||
| "github.com/akuity/bookkeeper/internal/kustomize" | ||
| "github.com/akuity/bookkeeper/internal/ytt" | ||
| ) | ||
|
|
||
| func TestPreRender(t *testing.T) { | ||
| const testAppName = "test-app" | ||
| fakeManifest := []byte("fake-manifest") | ||
| testCases := []struct { | ||
| name string | ||
| rc renderRequestContext | ||
| service *service | ||
| assertions func(manifests map[string][]byte, err error) | ||
| }{ | ||
| { | ||
| name: "error pre-rendering with helm", | ||
| rc: renderRequestContext{ | ||
| target: targetContext{ | ||
| branchConfig: branchConfig{ | ||
| AppConfigs: map[string]appConfig{ | ||
| testAppName: { | ||
| ConfigManagement: configManagementConfig{ | ||
| Helm: &helm.Config{}, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| service: &service{ | ||
| helmRenderFn: func( | ||
| context.Context, | ||
| string, | ||
| string, | ||
| []string, | ||
| ) ([]byte, error) { | ||
| return nil, errors.New("something went wrong") | ||
| }, | ||
| }, | ||
| assertions: func(_ map[string][]byte, err error) { | ||
| require.Error(t, err) | ||
| require.Equal(t, "something went wrong", err.Error()) | ||
| }, | ||
| }, | ||
| { | ||
| name: "success pre-rendering with helm", | ||
| rc: renderRequestContext{ | ||
| target: targetContext{ | ||
| branchConfig: branchConfig{ | ||
| AppConfigs: map[string]appConfig{ | ||
| testAppName: { | ||
| ConfigManagement: configManagementConfig{ | ||
| Helm: &helm.Config{}, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| service: &service{ | ||
| helmRenderFn: func( | ||
| context.Context, | ||
| string, | ||
| string, | ||
| []string, | ||
| ) ([]byte, error) { | ||
| return fakeManifest, nil | ||
| }, | ||
| }, | ||
| assertions: func(manifests map[string][]byte, err error) { | ||
| require.NoError(t, err) | ||
| require.Equal(t, fakeManifest, manifests[testAppName]) | ||
| }, | ||
| }, | ||
| { | ||
| name: "error pre-rendering with ytt", | ||
| rc: renderRequestContext{ | ||
| target: targetContext{ | ||
| branchConfig: branchConfig{ | ||
| AppConfigs: map[string]appConfig{ | ||
| "test-app": { | ||
| ConfigManagement: configManagementConfig{ | ||
| Ytt: &ytt.Config{}, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| service: &service{ | ||
| yttRenderFn: func(context.Context, []string) ([]byte, error) { | ||
| return nil, errors.New("something went wrong") | ||
| }, | ||
| }, | ||
| assertions: func(_ map[string][]byte, err error) { | ||
| require.Error(t, err) | ||
| require.Equal(t, "something went wrong", err.Error()) | ||
| }, | ||
| }, | ||
| { | ||
| name: "success pre-rendering with ytt", | ||
| rc: renderRequestContext{ | ||
| target: targetContext{ | ||
| branchConfig: branchConfig{ | ||
| AppConfigs: map[string]appConfig{ | ||
| "test-app": { | ||
| ConfigManagement: configManagementConfig{ | ||
| Ytt: &ytt.Config{}, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| service: &service{ | ||
| yttRenderFn: func(context.Context, []string) ([]byte, error) { | ||
| return fakeManifest, nil | ||
| }, | ||
| }, | ||
| assertions: func(manifests map[string][]byte, err error) { | ||
| require.NoError(t, err) | ||
| require.Equal(t, fakeManifest, manifests[testAppName]) | ||
| }, | ||
| }, | ||
| { | ||
| name: "error pre-rendering with kustomize", | ||
| rc: renderRequestContext{ | ||
| target: targetContext{ | ||
| branchConfig: branchConfig{ | ||
| AppConfigs: map[string]appConfig{ | ||
| "test-app": { | ||
| ConfigManagement: configManagementConfig{ | ||
| Kustomize: &kustomize.Config{}, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| service: &service{ | ||
| kustomizeRenderFn: func( | ||
| context.Context, | ||
| string, | ||
| []string, | ||
| bool, | ||
| ) ([]byte, error) { | ||
| return nil, errors.New("something went wrong") | ||
| }, | ||
| }, | ||
| assertions: func(manifests map[string][]byte, err error) { | ||
| require.Error(t, err) | ||
| require.Equal(t, "something went wrong", err.Error()) | ||
| }, | ||
| }, | ||
| { | ||
| name: "success pre-rendering with kustomize", | ||
| rc: renderRequestContext{ | ||
| target: targetContext{ | ||
| branchConfig: branchConfig{ | ||
| AppConfigs: map[string]appConfig{ | ||
| "test-app": { | ||
| ConfigManagement: configManagementConfig{ | ||
| Kustomize: &kustomize.Config{}, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| service: &service{ | ||
| kustomizeRenderFn: func( | ||
| context.Context, | ||
| string, | ||
| []string, | ||
| bool, | ||
| ) ([]byte, error) { | ||
| return fakeManifest, nil | ||
| }, | ||
| }, | ||
| assertions: func(manifests map[string][]byte, err error) { | ||
| require.NoError(t, err) | ||
| require.Equal(t, fakeManifest, manifests[testAppName]) | ||
| }, | ||
| }, | ||
| { | ||
| name: "safeguards against empty manifests", | ||
| rc: renderRequestContext{ | ||
| target: targetContext{ | ||
| branchConfig: branchConfig{ | ||
| AppConfigs: map[string]appConfig{ | ||
| "test-app": { | ||
| ConfigManagement: configManagementConfig{ | ||
| Kustomize: &kustomize.Config{}, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| service: &service{ | ||
| kustomizeRenderFn: func( | ||
| context.Context, | ||
| string, | ||
| []string, | ||
| bool, | ||
| ) ([]byte, error) { | ||
| return []byte{}, nil // This is probably a mistake! | ||
| }, | ||
| }, | ||
| assertions: func(manifests map[string][]byte, err error) { | ||
| require.Error(t, err) | ||
| require.Contains( | ||
| t, | ||
| err.Error(), | ||
| "contain 0 bytes; this looks like a mistake", | ||
| ) | ||
| }, | ||
| }, | ||
| } | ||
| for _, testCase := range testCases { | ||
| t.Run(testCase.name, func(t *testing.T) { | ||
| testCase.rc.logger = &logrus.Entry{ | ||
| Logger: logrus.New(), | ||
| } | ||
| testCase.assertions( | ||
| testCase.service.preRender( | ||
| context.Background(), | ||
| testCase.rc, | ||
| "fake/repo/path", | ||
| ), | ||
| ) | ||
| }) | ||
| } | ||
| } |
Oops, something went wrong.