Skip to content

Commit

Permalink
fix(promotion): wait for open pull request (#2451)
Browse files Browse the repository at this point in the history
Signed-off-by: Hidde Beydals <[email protected]>
(cherry picked from commit bab3322)
  • Loading branch information
hiddeco authored and github-actions[bot] committed Aug 21, 2024
1 parent 5b6cfa0 commit 8bde16c
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion internal/controller/promotion/pullrequest.go
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,9 @@ func reconcilePullRequest(
if err != nil {
return "", err
}
if !pr.IsOpen() {
if pr.IsOpen() {
promo.Status.Phase = kargoapi.PromotionPhaseRunning
} else {

Check warning on line 168 in internal/controller/promotion/pullrequest.go

View check run for this annotation

Codecov / codecov/patch

internal/controller/promotion/pullrequest.go#L166-L168

Added lines #L166 - L168 were not covered by tests
merged, err := gpClient.IsPullRequestMerged(ctx, prNumber)
if err != nil {
return "", err
Expand Down

0 comments on commit 8bde16c

Please sign in to comment.