Skip to content

Commit

Permalink
docs: adjusts deprecation notices (#3015)
Browse files Browse the repository at this point in the history
Signed-off-by: Kent Rancourt <[email protected]>
  • Loading branch information
krancour authored Nov 27, 2024
1 parent ad139d2 commit 92f7360
Show file tree
Hide file tree
Showing 7 changed files with 24 additions and 22 deletions.
34 changes: 17 additions & 17 deletions docs/docs/35-references/10-promotion-steps.md

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion internal/directives/argocd_updater.go
Original file line number Diff line number Diff line change
Expand Up @@ -858,7 +858,7 @@ func (a *argocdUpdater) buildHelmParamChangesForAppSource(
imageUpdate := &update.Images[i]
switch imageUpdate.Value {
case ImageAndTag, Tag, ImageAndDigest, Digest:
// TODO(krancour): Remove this for v1.2.0
// TODO(krancour): Remove this for v1.3.0
desiredOrigin := getDesiredOrigin(stepCfg, imageUpdate)
image, err := freight.FindImage(
ctx,
Expand Down
2 changes: 1 addition & 1 deletion internal/directives/git_cloner.go
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ func (g *gitCloner) runPromotionStep(
ref = checkout.Commit
case checkout.Tag != "":
ref = checkout.Tag
// TODO(krancour): Remove for v1.2.0.
// TODO(krancour): Remove for v1.3.0.
case checkout.FromFreight:
var desiredOrigin *kargoapi.FreightOrigin
if checkout.FromOrigin != nil {
Expand Down
2 changes: 1 addition & 1 deletion internal/directives/helm_chart_updater.go
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ func (h *helmChartUpdater) processChartUpdates(
for _, update := range cfg.Charts {
version := update.Version
if update.Version == "" {
// TODO(krancour): Remove this for v1.2.0
// TODO(krancour): Remove this for v1.3.0
repoURL, chartName := normalizeChartReference(update.Repository, update.Name)
var desiredOrigin *kargoapi.FreightOrigin
if update.FromOrigin != nil {
Expand Down
2 changes: 1 addition & 1 deletion internal/directives/helm_common.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package directives

// TODO(krancour): Remove this for v1.2.0
// TODO(krancour): Remove this for v1.3.0
const (
Digest = "Digest"
ImageAndDigest = "ImageAndDigest"
Expand Down
2 changes: 2 additions & 0 deletions internal/directives/helm_image_updater.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ func init() {

// helmImageUpdater is an implementation of the PromotionStepRunner interface
// that updates image references in a Helm values file.
//
// TODO(krancour): Remove for v1.3.0.
type helmImageUpdater struct {
schemaLoader gojsonschema.JSONLoader
}
Expand Down
2 changes: 1 addition & 1 deletion internal/directives/kustomize_image_setter.go
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ func (k *kustomizeImageSetter) buildTargetImages(
targetImage.Digest = img.Digest
} else if img.Tag != "" {
targetImage.NewTag = img.Tag
} else { // TODO(krancour): Remove this for v1.2.0
} else { // TODO(krancour): Remove this for v1.3.0
var desiredOrigin *kargoapi.FreightOrigin
if img.FromOrigin != nil {
desiredOrigin = &kargoapi.FreightOrigin{
Expand Down

0 comments on commit 92f7360

Please sign in to comment.