-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR Labels #3002
Comments
I suspect there are a number of things that could be done here and you guys just haven't gotten to it yet. For instance, it would be nice to be able to specify what the PR title is to override using the last commit message. |
PR labels seem like a sensible request and one that's easy enough to implement. Same for title. Setting a custom title didn't make sense prior to expression language support because all your PR titles from a given Stage's Promotions would have been static/identical. With expressions, it should be possible to dynamically build a more meaningful title. If you don't mind, please open a separate issue for that. |
done |
I'd be interested in taking a stab at this one 🙂 |
Signed-off-by: Dominik Münch <[email protected]>
Signed-off-by: Dominik Münch <[email protected]>
Signed-off-by: Dominik Münch <[email protected]>
Signed-off-by: Dominik Münch <[email protected]>
Signed-off-by: Dominik Münch <[email protected]>
Signed-off-by: Dominik Münch <[email protected]>
Checklist
kargo version
, if applicable.kargo v1.0.3
Proposed Feature
It would be really great if we could set PR labels via the git-open-pr step.
Motivation
We like to use them to filter our PRs in github and it would be nice if we didn't have to do this after the PR is created.
Additionally, one could have a github action triggered based on the label being added and the value. While I don't have an immediate use case for this, I could see how I might use it.
Suggested Implementation
The git-open-pr promotion step could have a configuration item that is Labels that is of type list of strings. Each item in the list is added as a label after the PR is opened.
It would be worth noting that the labels have to pre-exist in your github repo for the workflow to add the label, but that would be on the creator of the workflow to insure.
The text was updated successfully, but these errors were encountered: