Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PR labels (#3002) #3118

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: PR labels (#3002) #3118

wants to merge 2 commits into from

Conversation

muenchdo
Copy link
Contributor

closes #3002

Signed-off-by: Dominik Münch <[email protected]>
Copy link

netlify bot commented Dec 10, 2024

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit 321ec4c
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/675940311399770008949296
😎 Deploy Preview https://deploy-preview-3118.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 52.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 51.45%. Comparing base (aecc74f) to head (321ec4c).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
internal/gitprovider/github/github.go 47.82% 11 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3118      +/-   ##
==========================================
+ Coverage   51.26%   51.45%   +0.19%     
==========================================
  Files         283      283              
  Lines       25563    25584      +21     
==========================================
+ Hits        13104    13164      +60     
+ Misses      11762    11713      -49     
- Partials      697      707      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muenchdo
Copy link
Contributor Author

@krancour I went down the rabbit hole of adding tests for the GitHub provider. Please let me know if this is generally going in a direction you like or whether the added complexity for these new tests is too much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PR Labels
2 participants