Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use builtin Kubernetes feature for gRPC health check #3038

Open
hiddeco opened this issue Dec 2, 2024 · 4 comments
Open

Use builtin Kubernetes feature for gRPC health check #3038

hiddeco opened this issue Dec 2, 2024 · 4 comments
Assignees
@hiddeco
Labels
area/api area/charts blocked-upstream Blocked from progressing further until an issue upstream (i.e. a dependency) has been resolved. dependencies Pull requests that update a dependency file kind/chore priority/low size/tiny Less than 1 hour of work

Comments

@hiddeco
Copy link
Contributor

hiddeco commented Dec 2, 2024

Since Kubernetes 1.27 (available since April 2023), there is a built-in gRPC liveness probe available.

We should consider starting to use this to free ourselves from the dependency on grpc_health_probe, which we have to bake into our image (and keep updated).
@hiddeco hiddeco added priority/low area/charts area/api dependencies Pull requests that update a dependency file size/tiny Less than 1 hour of work labels Dec 2, 2024
@hiddeco
Copy link
Contributor Author

hiddeco commented Dec 2, 2024

@krancour @jessesuen what Kubernetes versions are we officially supporting? Anything that is not EOL?

@krancour
Copy link
Member

krancour commented Dec 3, 2024

It's not something we've formally established yet.

Anything that is not EOL?

That would be my vote, but that means v1.29+.

I defer to @jessesuen.

@jessesuen
Copy link
Member

I think we can make the built-in probe the new default. The probes have seems to have been available in beta since v1.24, so we shouldn't break anyone.

@hiddeco hiddeco added this to the v1.2.0 milestone Dec 3, 2024
@hiddeco hiddeco self-assigned this Dec 3, 2024
@hiddeco hiddeco mentioned this issue Dec 3, 2024
Merged
@hiddeco
Copy link
Contributor Author

hiddeco commented Dec 3, 2024

As noted in #3041, we can not fully adopt this until Kubernetes starts to support TLS in the built-in probe.

@hiddeco hiddeco added the blocked-upstream Blocked from progressing further until an issue upstream (i.e. a dependency) has been resolved. label Dec 11, 2024
@krancour krancour removed this from the v1.2.0 milestone Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hiddeco hiddeco

Labels
area/api area/charts blocked-upstream Blocked from progressing further until an issue upstream (i.e. a dependency) has been resolved. dependencies Pull requests that update a dependency file kind/chore priority/low size/tiny Less than 1 hour of work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@krancour @hiddeco @jessesuen