chore(chart): start using Kubernetes' builtin gRPC probe #3041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hidde Beydals <[email protected]>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This kind of conflicts with what is being attempted in #2906. |
|
Let's get this in ahead of #2906. |
krancour
approved these changes
Dec 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3041 +/- ##
=======================================
Coverage 51.10% 51.10%
=======================================
Files 283 283
Lines 25398 25398
=======================================
Hits 12979 12979
Misses 11720 11720
Partials 699 699 ☔ View full report in Codecov by Sentry. |
diegocaspi
pushed a commit
to diegocaspi/kargo
that referenced
this pull request
Dec 18, 2024
Signed-off-by: Hidde Beydals <[email protected]> Signed-off-by: Diego Caspi <[email protected]>
fykaa
pushed a commit
to fykaa/kargo
that referenced
this pull request
Dec 20, 2024
Signed-off-by: Hidde Beydals <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3038
This starts to make use of the builtin gRPC probe in an attempt to eventually drop our dependency on
grpc_health_probe.Sadly, however, the builtin probe does not support TLS (kubernetes/kubernetes#128365) (or disabling verification), and we can thus not drop the
grpc_health_probebinary yet.