feat(directives): support multi file write for helm-template
#2619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
force-pushed
the
helm-write-multi-files
branch
from
e15a593 to
fbdcead
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2619 +/- ##
==========================================
+ Coverage 50.97% 51.03% +0.05%
==========================================
Files 282 282
Lines 21039 21099 +60
==========================================
+ Hits 10724 10767 +43
- Misses 9643 9652 +9
- Partials 672 680 +8 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
force-pushed
the
helm-write-multi-files
branch
from
d71b4dc to
dd4113c
Compare
krancour
approved these changes
Oct 2, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 2, 2024
Signed-off-by: Hidde Beydals <[email protected]> (cherry picked from commit 79bbc2b)
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helm-related part for #2596.
This makes the directive behave the same as
helm templatewhen passing a directory (non.yamlor.yml) as output path. Writing each manifests to<outPath>/<chartName>/<pathInChart>, or<outPath>/<releaseName>/<pathInChart>whenuseReleaseNameis configured.