Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(directives): support writing kustomize output to multiple files #2630

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

hiddeco
Copy link
Contributor

@hiddeco hiddeco commented Oct 2, 2024

Fixes #2596

Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit de2224b
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/66fd803f11b160000841bb70
😎 Deploy Preview https://deploy-preview-2630.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 34.61538% with 17 lines in your changes missing coverage. Please review.

Project coverage is 51.02%. Comparing base (34e599d) to head (e646bc1).

Files with missing lines Patch % Lines
internal/directives/kustomize_builder.go 34.61% 10 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2630      +/-   ##
==========================================
- Coverage   51.03%   51.02%   -0.01%     
==========================================
  Files         282      282              
  Lines       21099    21118      +19     
==========================================
+ Hits        10767    10775       +8     
- Misses       9652     9659       +7     
- Partials      680      684       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hiddeco hiddeco force-pushed the kustomize-write-multi-files branch from b8af35a to e646bc1 Compare October 2, 2024 17:09
@hiddeco hiddeco marked this pull request as ready for review October 2, 2024 17:09
@hiddeco hiddeco requested a review from a team as a code owner October 2, 2024 17:09
@hiddeco hiddeco force-pushed the kustomize-write-multi-files branch from e646bc1 to 54371d3 Compare October 2, 2024 17:16
@krancour krancour enabled auto-merge October 2, 2024 17:16
@hiddeco hiddeco force-pushed the kustomize-write-multi-files branch from 54371d3 to de2224b Compare October 2, 2024 17:17
@hiddeco hiddeco disabled auto-merge October 2, 2024 17:18
@hiddeco hiddeco enabled auto-merge October 2, 2024 17:18
@hiddeco hiddeco added this pull request to the merge queue Oct 2, 2024
Merged via the queue into akuity:main with commit 826831c Oct 2, 2024
15 checks passed
@hiddeco hiddeco deleted the kustomize-write-multi-files branch October 2, 2024 17:38
github-actions bot pushed a commit that referenced this pull request Oct 2, 2024
@akuitybot
Copy link

Marvin9 pushed a commit that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: allow kustomize-build and helm-template promotion steps to break up output into a file per resource
3 participants