fix: missing enumerated values in generated docs for warehouse #2969
Conversation
Signed-off-by: Faeka Ansari <[email protected]>
Signed-off-by: Faeka Ansari <[email protected]>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2969 +/- ##
=======================================
Coverage 50.91% 50.91%
=======================================
Files 279 279
Lines 25175 25175
=======================================
Hits 12818 12818
Misses 11666 11666
Partials 691 691 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
| @@ -67,6 +67,7 @@ type WarehouseSpec struct { | |||
| // FreightCreationPolicy describes how Freight is created by this Warehouse. | |||
| // This field is optional. When left unspecified, the field is implicitly | |||
| // treated as if its value were "Automatic". | |||
| // Accepted values: Automatic, Manual | |||
There was a problem hiding this comment.
Nice catch. I overlooked this.
|
This is a good start. I'll approve because I'd like to see this information out into the real world sooner rather than later, but we should follow-up in the very near future to document the behavior of each of those strategies. |
Signed-off-by: Faeka Ansari <[email protected]> (cherry picked from commit 27f501c)
|
Successfully created backport PR for |
this PR tries to talk about the behavior of each strategy |
closes #2880
doc ref: #2963