Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor retries #3060

Merged
merged 6 commits into from
Dec 5, 2024

address @hiddeco feedback

743a0d8
Select commit
Loading
Failed to load commit list.
Merged

fix: refactor retries #3060

address @hiddeco feedback
743a0d8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 5, 2024 in 1s

51.22% (+0.11%) compared to 3a7cbb3

View this Pull Request on Codecov

51.22% (+0.11%) compared to 3a7cbb3

Details

Codecov Report

Attention: Patch coverage is 76.08696% with 33 lines in your changes missing coverage. Please review.

Project coverage is 51.22%. Comparing base (3a7cbb3) to head (743a0d8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/controller/promotions/promotions.go 0.00% 20 Missing ⚠️
internal/directives/simple_engine_promote.go 92.55% 6 Missing and 1 partial ⚠️
internal/directives/argocd_updater.go 0.00% 4 Missing ⚠️
api/v1alpha1/promotion_types.go 80.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3060      +/-   ##
==========================================
+ Coverage   51.10%   51.22%   +0.11%     
==========================================
  Files         283      283              
  Lines       25410    25456      +46     
==========================================
+ Hits        12987    13039      +52     
+ Misses      11724    11720       -4     
+ Partials      699      697       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov