feat: (cluster) Promotion tasks #3121
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3121 +/- ##
==========================================
+ Coverage 51.26% 51.48% +0.22%
==========================================
Files 283 285 +2
Lines 25563 25731 +168
==========================================
+ Hits 13104 13248 +144
- Misses 11762 11786 +24
Partials 697 697 ☔ View full report in Codecov by Sentry. |
hiddeco
force-pushed
the
promotion-tasks
branch
from
242b4e6 to
ffc480b
Compare
hiddeco
force-pushed
the
promotion-tasks
branch
2 times, most recently
from
9d1386a to
caab6b6
Compare
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
- `PromotionTemplate` steps can contain either a reference to `uses` OR to a `task`. - `PromotionTask` steps can not contain a reference to another `task`, but must contain a `uses` reference. - `Promotion` steps can not contain a reference to a `task` (as we expect a `Promotion` to contain deflated tasks), but must contain a `uses` reference. - Small other tweaks, to e.g. ensure we limit the max lenght of fields that contain name references to Kubernetes objects. Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
This includes validation rules to ensure a `PromotionTask` step can not have `inputs` defined, but `Promotion` and `PromotionTemplate` steps can (unless they reference a `task` themselves). Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
The builder is capable of inflating steps from a (Cluster)PromotionTask into the Promotion it constructs. To support this, a helper method has been added to the `PromotionStep` in the (public) API to generate an alias for the step if none is configured. Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
force-pushed
the
promotion-tasks
branch
from
4645320 to
3b8f9c6
Compare
Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
force-pushed
the
promotion-tasks
branch
2 times, most recently
from
eda8391 to
f789867
Compare
hiddeco
force-pushed
the
promotion-tasks
branch
from
f789867 to
0102ace
Compare
Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
force-pushed
the
promotion-tasks
branch
2 times, most recently
from
10671e1 to
7f0be4c
Compare
Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
force-pushed
the
promotion-tasks
branch
from
7f0be4c to
9d08e30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very much a work in progress, and will supersede #3022.