Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): PR deep links in Promotion steps and in Promotion lists #3129

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Marvin9
Copy link
Contributor

@Marvin9 Marvin9 commented Dec 12, 2024

fixes #3024

Other than fix. This PR does some works for

  • Lays very soft foundation for future plugin architecture. UI takes opportunity of learn possible ways to split plugins. Note that this is not final and subject to change based on discussions when time comes but at the very least makes it easier to break into pieces
  • Removes the icons in promotion steps.. with deep links, it looked more busy with icons.
Screen.Recording.2024-12-12.at.4.42.55.PM.mov

Will cleanup some UI a bit but other than that its ready to review

Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
@Marvin9 Marvin9 added this to the v1.1.2 milestone Dec 12, 2024
@Marvin9 Marvin9 self-assigned this Dec 12, 2024
@Marvin9 Marvin9 requested a review from a team as a code owner December 12, 2024 20:50
Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit 3adcf8b
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/675b56feca565b000850383e
😎 Deploy Preview https://deploy-preview-3129.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Marvin9 Marvin9 requested review from krancour and rpelczar December 12, 2024 20:52
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.26%. Comparing base (230f81b) to head (3adcf8b).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3129   +/-   ##
=======================================
  Coverage   51.26%   51.26%           
=======================================
  Files         283      283           
  Lines       25563    25563           
=======================================
  Hits        13104    13104           
  Misses      11762    11762           
  Partials      697      697           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PR link no longer displayed in the Promotion UI
1 participant