History controller refactored #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yescorp
commented
Feb 15, 2023
•
yescorp
commented
- Resolves Undo sets the cursor to the beginning of the document #132
- Resolves Undo action issue #186
- Resolves For discussion: History controller interaction with folding #193
added 2 commits
February 15, 2023 10:33
Codecov Report
@@ Coverage Diff @@
## main #187 +/- ##
==========================================
+ Coverage 82.24% 82.51% +0.26%
==========================================
Files 85 85
Lines 2557 2602 +45
==========================================
+ Hits 2103 2147 +44
- Misses 454 455 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
alexeyinkin
suggested changes
Feb 16, 2023
alexeyinkin
suggested changes
Feb 17, 2023
added 2 commits
February 17, 2023 18:53
alexeyinkin
suggested changes
Feb 17, 2023
| expect(controller.historyController.stack.length, 6); | ||
| expect(controller.code.text, code2.text); | ||
| expect(controller.selection, selection2); | ||
| for (int i = manualHistoryRecords.length - 2; i >= 0; i--) { |
There was a problem hiding this comment.
Suggested change
| for (int i = manualHistoryRecords.length - 2; i >= 0; i--) { | |
| for (int i = manualHistoryRecords.length - 1; --i >= 0; ) { |
Comment on lines
478
to
479
| firstCode ??= controller.code; | ||
| firstSelection ??= controller.selection; |
There was a problem hiding this comment.
codeAfterFirstEdit, selectionAfterFirstEdit
// Set after the first change.
alexeyinkin
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.