Skip to content

Commit

Permalink
Merge pull request troglobit#62 from al20878/master
Browse files Browse the repository at this point in the history
Fix troglobit#61: gcc sign extension warnings

Signed-off-by: Joachim Wiberg <[email protected]>
  • Loading branch information
troglobit authored Oct 23, 2022
2 parents 9fa05ba + c50d4c3 commit 3ccc3a5
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 8 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,7 @@ current maintainer works exclusively on GNU/Linux systems, so it may use
GCC and GNU Make specific extensions here and there. This is not on
purpose and patches or pull requests to correct this are most welcome!

0. Call <kbd>./automake.sh</kbd> if you build from git
1. Configure editline with default features: <kbd>./configure</kbd>
2. Build the library and examples: <kbd>make all</kbd>
3. Install using <kbd>make install</kbd>
Expand Down
4 changes: 2 additions & 2 deletions src/complete.c
Original file line number Diff line number Diff line change
Expand Up @@ -278,15 +278,15 @@ static char *rl_find_token(size_t *len)
int pos;

for (pos = rl_point; pos < rl_end; pos++) {
if (isspace(rl_line_buffer[pos])) {
if (isspace((unsigned char) rl_line_buffer[pos])) {
if (pos > 0)
pos--;
break;
}
}

ptr = &rl_line_buffer[pos];
while (pos >= 0 && !isspace(rl_line_buffer[pos])) {
while (pos >= 0 && !isspace((unsigned char) rl_line_buffer[pos])) {
if (pos == 0)
break;

Expand Down
12 changes: 6 additions & 6 deletions src/editline.c
Original file line number Diff line number Diff line change
Expand Up @@ -494,10 +494,10 @@ static el_status_t do_case(el_case_t type)

for (i = rl_point, p = &rl_line_buffer[i]; rl_point < end; p++) {
if ((type == TOupper) || (type == TOcapitalize && rl_point == i)) {
if (islower(*p))
*p = toupper(*p);
} else if (isupper(*p)) {
*p = tolower(*p);
if (islower((unsigned char)(*p)))
*p = toupper((unsigned char)(*p));
} else if (isupper((unsigned char)(*p))) {
*p = tolower((unsigned char)(*p));
}
right(CSmove);
}
Expand Down Expand Up @@ -1875,14 +1875,14 @@ static int argify(char *line, char ***avp)
if (!p)
return 0;

for (c = line; isspace(*c); c++)
for (c = line; isspace((unsigned char)(*c)); c++)
continue;

if (*c == '\n' || *c == '\0')
return 0;

for (ac = 0, p[ac++] = c; *c && *c != '\n'; ) {
if (!isspace(*c)) {
if (!isspace((unsigned char)(*c))) {
c++;
continue;
}
Expand Down

0 comments on commit 3ccc3a5

Please sign in to comment.