Use rchunks_exact for a performance improvement

alajpie · Jun 16, 2020 · 8ce9d3d · 8ce9d3d
1 parent 103fdb7
commit 8ce9d3d
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 12 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "urbit-q"
-version = "0.1.1"
+version = "0.1.2"
 authors = ["k2l8m11n2"]
 edition = "2018"
 description = "Encode and decode data in Urbit's @q format"

diff --git a/src/lib.rs b/src/lib.rs
@@ -38,17 +38,18 @@ pub fn encode(input: &[u8]) -> String {
         output.push_str(consts::PREFIXES[0]);
     }
     let mut dashes_placed = 0;
-    for pair in input.rchunks(2).rev() {
-        match pair.len() {
-            1 => {
-                output.push_str(consts::SUFFIXES[pair[0] as usize]);
-            }
-            2 => {
-                output.push_str(consts::PREFIXES[pair[0] as usize]);
-                output.push_str(consts::SUFFIXES[pair[1] as usize]);
-            }
-            _ => unreachable!(),
+    let iter = input.rchunks_exact(2);
+    let remainder = iter.remainder();
+    if remainder.len() != 0 {
+        output.push_str(consts::SUFFIXES[remainder[0] as usize]);
+        if dashes_placed != dashes {
+            output.push('-');
+            dashes_placed += 1;
         }
+    }
+    for pair in iter.rev() {
+        output.push_str(consts::PREFIXES[pair[0] as usize]);
+        output.push_str(consts::SUFFIXES[pair[1] as usize]);
         if dashes_placed != dashes {
             output.push('-');
             dashes_placed += 1;