feat: add png rendering action to the Metabase piece #93
Conversation
| if (response.error) { | ||
| throw new Error(response.error); | ||
| } | ||
| return response; |
There was a problem hiding this comment.
What's the output? a URL, a base64 image, or something else?
There was a problem hiding this comment.
It's an entire HTML file (but when I open it in the browser I can see the PNG)
There was a problem hiding this comment.
When I test "Get Question" locally, I also get an HTML file so I thought that was expected. However, when I execute "Get Question" in staging it returns a JSON...
There was a problem hiding this comment.
You're supposed to get a JSON indeed - the html is possibly an error page?
For the PNG: can you try calling the API manually with the token (e.g. with curl) to see the exact expected response? I'm surprised it's HTML - we can work with that but it's more difficult than needed
There was a problem hiding this comment.
the html is possibly an error page?
No actually, that's what's super weird! 😅 When I open the HTML page in the browser I do see the expected result which is the PNG of the question, whether it's a viz or a table....
There was a problem hiding this comment.
can we isolate the actual PNG? Is it a data: blob or an actual file hosted on the metabase server?
valentin-mourtialon
force-pushed
the
valentinmourtialon/feat/metabase-png-rendering
branch
from
50155b5 to
68c9df2
Compare
| const questionId = propsValue.questionId.split('-')[0]; | ||
|
|
||
| const response = await fetch( | ||
| `${auth.baseUrl}/api/pulse/preview_card_png/${questionId}`, |
There was a problem hiding this comment.
I did not use the helper you made because I didn't want to change both the common.ts and the get-png-rendering.ts in the same PR
There was a problem hiding this comment.
Why would you need to modify the helper?
And you can definitely update both in the same PR if it's required for your change!
valentin-mourtialon
force-pushed
the
valentinmourtialon/feat/metabase-png-rendering
branch
from
68c9df2 to
e4770b8
Compare
|
|
||
| return { | ||
| fileName: `metabase_question_${questionId}.png`, | ||
| file: fileUrl, |
There was a problem hiding this comment.
file is more user friendly than url, less misleading
|
Tested in a flow where I sent myself an email with the PNG as an attachment, and it worked. |
| const questionId = propsValue.questionId.split('-')[0]; | ||
|
|
||
| const response = await fetch( | ||
| `${auth.baseUrl}/api/pulse/preview_card_png/${questionId}`, |
There was a problem hiding this comment.
Why would you need to modify the helper?
And you can definitely update both in the same PR if it's required for your change!
valentin-mourtialon
force-pushed
the
valentinmourtialon/feat/metabase-png-rendering
branch
from
e4770b8 to
1ffcdcb
Compare
valentin-mourtialon
deleted the
valentinmourtialon/feat/metabase-png-rendering
branch
What does this PR do?
Add the
getQuestionPngPreviewaction to the Metabase piece.