Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R docker refactor for lab sessions #122

Merged
merged 89 commits into from
Feb 5, 2024
Merged

R docker refactor for lab sessions #122

merged 89 commits into from
Feb 5, 2024

Conversation

griff-rees
Copy link
Collaborator

This branch includes the docker deploy used for the workshop in December and subsequent configurations for potential jupyterhub deploys.

Merge branch 'LCAT.data' of https://github.com/alan-turing-institute/clim-recal into LCAT.data

# Conflicts:
#	R/bias-correction-methods/apply_qmapQuant_to_crpd_df_fn.R
@griff-rees griff-rees mentioned this pull request Jan 26, 2024
andrewphilipsmith

This comment was marked as outdated.

Copy link
Collaborator

@andrewphilipsmith andrewphilipsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. There are a couple of minor typos and docstring improvements that would be worth fixing, but otherwise ready to merge. 🎉

python/load_data/data_loader.py Outdated Show resolved Hide resolved
python/resampling/resampling_hads.py Outdated Show resolved Hide resolved
python/utils.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@andrewphilipsmith andrewphilipsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@griff-rees griff-rees merged commit 822adc5 into main Feb 5, 2024
6 checks passed
@griff-rees griff-rees deleted the r-docker-refactor branch February 5, 2024 15:30
This was referenced Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python python code R R code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants