Merge pull request #105 from alan-turing-institute/check-experiment-fix

Check experiment fix
alan-turing-institute · Oct 15, 2024 · 2a9ee06 · 2a9ee06
2 parents af16d2f + 1ee2a19
commit 2a9ee06
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/src/prompto/judge.py b/src/prompto/judge.py
@@ -220,10 +220,8 @@ def create_judge_inputs(self, judge: list[str] | str) -> list[dict]:
                             INPUT_PROMPT=response["prompt"],
                             OUTPUT_RESPONSE=response["response"],
                         ),
-                        "api": self.judge_settings[j]["api"],
-                        "model_name": self.judge_settings[j]["model_name"],
-                        "parameters": self.judge_settings[j]["parameters"],
                     }
+                    | self.judge_settings[j]
                     | {f"input-{k}": v for k, v in response.items()}
                     for response in tqdm(
                         self.completed_responses,

diff --git a/src/prompto/scripts/check_experiment.py b/src/prompto/scripts/check_experiment.py
@@ -156,7 +156,7 @@ def is_valid_jsonl(
                         data["multimedia"], media_folder
                     )
                     issues.extend(multimedia_issues)
-                    multimedia_path_errors.add(path_errors)
+                    multimedia_path_errors.union(path_errors)
 
                 if "api" in data:
                     if data["api"] not in ASYNC_APIS: