-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flex gui #1
Open
dalnefre
wants to merge
22
commits into
main
Choose a base branch
from
flex-gui
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's just too much fun watching the site password change as you type to cover it up by default.
I originally had a single set of instructions for both the web page and the extension. This update provides instructions specific to the web page.
The Remember button should be enabled when the domain name, site name, and user name fields are filled in. It was also requiring the master password field have a value, which is an error.
There may be times when you want to want to forget the settings for a given domain name. When you click the forget button, the domain name is removed from database.domains and the site name is removed from database.sites if there are no more references to it.
Seems more direct, doesn't it?
Maintain a cached string of the settings loaded from the database in order to determine if/when the settings data-model has changed. Use this to implement settingsModified(), which influences the state of the Remember and Forget buttons in the GUI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed overhaul of GUI and clean up internal logic.