Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests and allow Symfony 5 #156

Merged
merged 9 commits into from
Apr 13, 2021
Merged

Fix tests and allow Symfony 5 #156

merged 9 commits into from
Apr 13, 2021

Conversation

func0der
Copy link
Contributor

@func0der func0der commented Apr 3, 2020 •
edited
Loading

In this PR you'll find:

  • Support for Symfony 5 components
  • Drop support for PHP 5, PHP >= 7.1
  • Use PHPUnit 6 only, because alternative PHPUnit version in dev dependencies are not needed

Basically included: #154

@func0der func0der changed the title Allow newest symfony libraries Fix tests and allow Symfony 5 Apr 3, 2020
@func0der func0der mentioned this pull request Apr 3, 2020
Closed
@jpgnz jpgnz mentioned this pull request Apr 16, 2020
Open
@jimmycleuren
Copy link

Can this be merged ?

@skalero01
Copy link

This should be merge as is required to work with Laravel 7 please

@func0der
Copy link
Contributor Author

func0der commented Oct 1, 2020

@nmaillat or @jygaulier
Any news?

@YadrovSergey
Copy link

UP!

@kasperhartwich
Copy link

@nmaillat Could you please merge this?

@nmaillat
Copy link
Member

@kasperhartwich
Thank you to @func0der for this work. We are apologizing for the delay.

@nmaillat nmaillat merged commit 915d604 into alchemy-fr:master Apr 13, 2021
This was referenced Apr 13, 2021
Closed
Closed
@func0der
Copy link
Contributor Author

Thanks, mate. :)

@func0der func0der deleted the allow-newest-symfony-libraries branch April 15, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@func0der @jimmycleuren @skalero01 @YadrovSergey @kasperhartwich @nmaillat