fix(alchemy-signer): fix the sign tx method to return the full tx

alchemyplatform · May 21, 2024 · 7c30cd3 · 7c30cd3
1 parent 7673fc5
commit 7c30cd3
Showing 1 changed file with 12 additions and 3 deletions.
diff --git a/packages/alchemy/src/signer/signer.ts b/packages/alchemy/src/signer/signer.ts
@@ -1,4 +1,4 @@
-import type { SmartAccountAuthenticator } from "@alchemy/aa-core";
+import { takeBytes, type SmartAccountAuthenticator } from "@alchemy/aa-core";
 import {
   hashMessage,
   hashTypedData,
@@ -215,11 +215,20 @@ export class AlchemySigner
     return this.inner.signRawMessage(messageHash);
   };
 
-  signTransaction: CustomSource["signTransaction"] = (tx, args) => {
+  signTransaction: CustomSource["signTransaction"] = async (tx, args) => {
     const serializeFn = args?.serializer ?? serializeTransaction;
     const serializedTx = serializeFn(tx);
+    const signatureHex = await this.inner.signRawMessage(
+      keccak256(serializedTx)
+    );
+
+    const signature = {
+      r: takeBytes(signatureHex, { count: 32 }),
+      s: takeBytes(signatureHex, { count: 32, offset: 32 }),
+      v: BigInt(takeBytes(signatureHex, { count: 1, offset: 64 })),
+    };
 
-    return this.inner.signRawMessage(keccak256(serializedTx));
+    return serializeFn(tx, signature);
   };
 
   /**