-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: eip-7702 ui demo #1302
base: adam/7702-core
Are you sure you want to change the base?
feat: eip-7702 ui demo #1302
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fcd2437
to
8bd2069
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested on the preview link & everything seems solid! left a couple of minor comments, but they are pretty nit-picky.
{/* <HelpTooltip text="An account powered by a smart contract to enable more features. Not an EOA. Recommended for new wallets." /> */} | ||
</div> | ||
<WalletTypeSwitch | ||
id="theme-switch" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❗ i think this was copied from the ThemeSwitch and would result in 2 elements on the page w/ the same id
className="mb-4 rounded-xl object-cover h-[222px] w-[326px]" | ||
width={326} | ||
height={222} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ nit: any reason for setting height & width via both tailwind as well as the Image props?
background: | ||
"linear-gradient(132deg, #FF9C27 0%, #FD48CE 100%)", | ||
WebkitBackgroundClip: "text", | ||
backgroundClip: "text", | ||
WebkitTextFillColor: "transparent", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌈 doesn't really matter, but tailwind has support for this: https://tailwindcss.com/docs/background-clip
/> | ||
<Stage | ||
icon={status.batch} | ||
description="Deploying your smart account..." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a little weird to me that it keeps the "deploying your smart account" stage whenever a user performs the "re-collect nft" action (when in reality that would only happen the first time they mint)... but probably not the biggest deal if it's a pain to change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good callout, you could create another MintStatus
value and track if it's the first time minting in useMint
with a useState
var
c0d52b7
to
847ab00
Compare
e49a208
to
3bd32b8
Compare
847ab00
to
7d20b9f
Compare
3bd32b8
to
628362c
Compare
feat: update 7702 mint flow to actually use 7702 feat: partial recurring transfer support feat: ui progress feat: react state management feat: add permission hooks to session key fix: add templates to demo build fix: declare env var in turbo feat: ui demo user card reflects 7702 delegation status (#1294) * feat: have user avatar reflect if account has been delegated * feat: reflects delegation status in user details card * fix: forces delegation status query to refetch until available * chore: updates comment * refactor: uses viem public client and refetches delegation addr when nftTransferred status changes * refactor: uses defined url constant * chore: removes unnecessary check fix: coalesce undefined code result fix: forces delegation query to refetch until available feat: updated 7702 info blurb chore: cleanup
628362c
to
fdcfe37
Compare
Pull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:write
)PR-Codex overview
This PR introduces several enhancements and new features to the
ui-demo
project, including new smart contracts, updated configurations, and improvements to the user interface for wallet management and transaction handling.Detailed summary
Counter
andNFT
smart contracts.WalletTypes
enum for wallet management.Configuration
component to switch wallet types.UserConnectionDetails
to show delegation status.useRecurringTransactions
.package.json
dependencies and configurations.