Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds mav2 webauthn signer #1313

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

linnall
Copy link
Collaborator

@linnall linnall commented Jan 31, 2025

Pull Request Checklist


PR-Codex overview

This PR introduces a WebAuthnValidationModule for encoding installation and uninstallation data, enhances the nativeSMASigner with a signatureType, and adds a webauthnMessageSigner function. It also defines a new SignatureType enum and updates the pack1271Signature function to accommodate it.

Detailed summary

  • Added WebAuthnValidationModule with methods encodeOnInstallData and encodeOnUninstallData.
  • Updated nativeSMASigner to include a signatureType property set to SignatureType.EOA.
  • Implemented webauthnMessageSigner function for packing signatures.
  • Introduced SignatureType enum with values EOA and NONE.
  • Modified pack1271Signature to handle signatureType in the packing process.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ❌ Failed (Inspect) Jan 31, 2025 0:32am
aa-sdk-ui-demo ❌ Failed (Inspect) Jan 31, 2025 0:32am

Copy link

graphite-app bot commented Jan 31, 2025

How to use the Graphite Merge Queue

Add the label graphite-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant