fix: syntax error in demo GA script & hydration warning #1333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These issues have been displaying in the console on the demo app:
The first is due to the GA ID not being quoted.
The second is due to the UserAvatar colors being randomly shuffled, so the colors to not match between the server and client render.
Pull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:write
)PR-Codex overview
This PR focuses on improving the
UserAvatar
component by changing the color shuffling logic to ensure consistent rendering between server and client. It also updates the Google Analytics configuration.Detailed summary
gtag
configuration syntax inGoogleAnalytics.tsx
.shuffleColors
withshuffleColorsDeterministically
inUserAvatar.tsx
for consistent color ordering.useMemo
dependency to includeaddress
inUserAvatar.tsx
.