docs: add transfer ownership guides for ma v2 #1400
Conversation
howydev
requested review from
moldy530,
rthomare,
dancoombs,
mokok123,
dphilipson,
linnall,
adamegyed,
Zer0dot,
jaypaik,
Blu-J,
noam-alchemy,
jakehobbs and
archit2407
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd the label graphite-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
|
|
||
| const newOwner = "0xd8da6bf26964af9d7eed9e03e53415d37aa96045"; | ||
|
|
||
| // The boolean parameter in updateFallbackSignerData indicates that the 1st owner is no longer an owner of the account |
There was a problem hiding this comment.
Isn't the boolean for setting whether or not the fallback signer (SMA logic) is disabled?
There was a problem hiding this comment.
yeah it is, but wanted to simplify/abstract the idea of a fallback signer, but that might not be possible
There was a problem hiding this comment.
changing to add it back
| description: Managing ownership on your Modular Account V2 | ||
| --- | ||
|
|
||
| # Managing Ownership |
There was a problem hiding this comment.
This makes sense to me, but reading this as someone who didn't know how to do this already left me
wondering if I could call updateFallbackSignerData with some address, then call it again with an additional address, will it keep adding additional owners?
I looked at the contract code and saw that there is only a single fallback signer address, so calling it additional times will just update/replace it. But might be good to mention that here?
Also it's a little unclear to me whether calling this is transferring ownership (removing the original owner) or if the "fallback signer" is a separate thing that is just for an additional signer.
There was a problem hiding this comment.
Good callout, updated to make it more clear!
|
|
||
| # Managing Ownership | ||
|
|
||
| You can add an owner to your account, or transfer ownership of your account with Modular Account V2. Adding an owner has the same flow as adding a session key with no root permissions. |
There was a problem hiding this comment.
If the below example transfers ownership (i.e. replaces the original owner), relating to my previous comment, I think it might make sense to not talk about being able to add an owner here above the example. Maybe it should go below the example like "If you want to add an additional owner without removing the original owner, you can do so by using session keys. (link to example)"
howydev
force-pushed
the
howy/add-session-key-docs
branch
2 times, most recently
from
05ea0ba to
46fe28a
Compare
howydev
force-pushed
the
howy/add-transfer-ownership
branch
from
6a559df to
e435f78
Compare
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR introduces a new section in the sidebar for "Managing ownership" related to
Modular Account V2. It adds documentation on how to manage ownership, specifically transferring ownership and adding a new owner using theupdateFallbackSignerDatafunction.Detailed summary
site/sidebar/smart-contracts.ts.managing-ownership.mdxwith:updateFallbackSignerData.