test: add prool instances setup #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moldy530
requested review from
rthomare,
dancoombs,
mokok123 and
dphilipson
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
moldy530
commented
Jul 22, 2024
moldy530
force-pushed
the
moldy/add-prool-instances
branch
from
242c15c to
f70c98e
Compare
moldy530
force-pushed
the
moldy/add-prool-instances
branch
from
f70c98e to
d4b8720
Compare
moldy530
force-pushed
the
moldy/add-prool-instances
branch
from
d4b8720 to
35fd30a
Compare
moldy530
force-pushed
the
moldy/add-prool-instances
branch
from
35fd30a to
e164b1a
Compare
moldy530
force-pushed
the
moldy/add-prool-instances
branch
from
e164b1a to
0e74e8e
Compare
moldy530
force-pushed
the
moldy/add-prool-instances
branch
from
0e74e8e to
b6ab7d4
Compare
moldy530
commented
Jul 23, 2024
moldy530
commented
Jul 23, 2024
package.json
Outdated
| @@ -16,6 +16,7 @@ | |||
| "scripts": { | |||
| "generate": "lerna run generate", | |||
| "postgenerate": "yarn lint:write", | |||
| "preinstall": "yarn config set ignore-engines true", | |||
There was a problem hiding this comment.
prool requires node >= 22, but vercel only goes as high as 20 and the ui-demo app doesn't deploy with node engine 20... so we just hope prool runs on 18 🤷
moldy530
force-pushed
the
moldy/add-prool-instances
branch
2 times, most recently
from
639118b to
c52b689
Compare
moldy530
force-pushed
the
moldy/add-prool-instances
branch
from
c52b689 to
d396483
Compare
rthomare
previously approved these changes
Jul 25, 2024
moldy530
force-pushed
the
moldy/add-prool-instances
branch
from
d396483 to
7703f58
Compare
moldy530
added a commit
that referenced
this pull request
Jul 30, 2024
moldy530
added a commit
that referenced
this pull request
Aug 13, 2024
moldy530
added a commit
that referenced
this pull request
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Updates the test setup to include starting prool servers for anvil and bundler
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR updates the test script in
package.jsonto run different commands based on the environment.Detailed summary
testscript to run different commands based on environment usingis-ciandvitestcommands.