add executeBatch with values and tests and update ERC1271 support docs #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fangting-alchemy
requested review from
dphilipson and
jaypaik
and removed request for
dphilipson and
jaypaik
adam-alchemy
approved these changes
Sep 8, 2023
| bytes[] memory func = new bytes[](1); | ||
| func[0] = abi.encodeCall(LightSwitch.turnOn, ()); | ||
| account.executeBatch(dest, value, func); | ||
| assertTrue(lightSwitch.on()); |
There was a problem hiding this comment.
could we add an assert here that the recipient contract's balance went up?
fangting-alchemy
force-pushed
the
fangting/batch
branch
from
4f71d9b
to
be05fbc
Compare
jaypaik
approved these changes
Sep 8, 2023
test/LightAccount.t.sol
Outdated
| @@ -47,6 +47,13 @@ contract LightAccountTest is Test { | |||
| assertTrue(lightSwitch.on()); | |||
| } | |||
|
|
|||
| function testExecuteWihValueCanBeCalledByOwner() public { | |||
There was a problem hiding this comment.
Super nit:
Suggested change
| function testExecuteWihValueCanBeCalledByOwner() public { | |
| function testExecuteWithValueCanBeCalledByOwner() public { |
fangting-alchemy
force-pushed
the
fangting/batch
branch
from
be05fbc
to
f2297e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.