fix: address best practices #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jaypaik
commented
Sep 20, 2023
jaypaik
commented
- Use custom errors in place of require statements for gas savings.
- Fixed.
- Address.isContract() will be removed in the OZ-contracts 5.0 release. Consider replacing it with (address(this).code.length > 0)
- Fixed.
- Typo "_getInitialiazableStorage()" ⇒ "_getInitializableStorage()".
- Fixed.
- Global state variables, such as CustomSlotInitializable._storagePosition , should not have a leading underscore.
- Acknowledged. We'll keep this to follow our convention of leading underscores for internal / private variables.
- For loops can be gas-optimized by cashing the array.length in a memory variable and incrementing the iterator via unchecked {++i;} .
- Fixed.
- LightAccount.transferOwnership() can be restricted to external visibility.
- Fixed.
- _getInitialiazableStorage() can load directly from a constant and does not need a temporary variable.
- Acknowledged. Assembly access to immutable variables is not supported, so we're keeping this.
jaypaik
force-pushed
the
09-20-_ALC-5_update_initialized_from_uint8_to_uint64
branch
from
ca6c9f3
to
5ee69ed
Compare
jaypaik
force-pushed
the
09-20-fix_address_best_practices
branch
from
87d33aa
to
581f73a
Compare
jaypaik
force-pushed
the
09-20-_ALC-5_update_initialized_from_uint8_to_uint64
branch
from
5ee69ed
to
9b88fbd
Compare
jaypaik
force-pushed
the
09-20-fix_address_best_practices
branch
from
581f73a
to
84716cf
Compare
howydev
force-pushed
the
09-20-_ALC-5_update_initialized_from_uint8_to_uint64
branch
from
2045691
to
bf99b74
Compare
howydev
force-pushed
the
09-20-fix_address_best_practices
branch
2 times, most recently
from
17e5df6
to
84716cf
Compare
…xplaining_contract_owner_limitations_for_user_operation_validation [ALC-2] add comment explaining contract owner limitations for user operation validation
…lized_from_uint8_to_uint64 [ALC-5] update initialized from uint8 to uint64
howydev
force-pushed
the
09-20-fix_address_best_practices
branch
from
84716cf
to
e07c3d6
Compare
howydev
merged commit 55ecfb5
into
09-20-_ALC-5_update_initialized_from_uint8_to_uint64
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.