Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: amend rpc name to eip7702auth #997

Closed
wants to merge 1 commit into from
Closed

Conversation

andysim3d
Copy link
Collaborator

[Closes/Fixes] #

Proposed Changes

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 36.00000% with 16 lines in your changes missing coverage. Please review.

Project coverage is 59.08%. Comparing base (c97e01d) to head (59fdcfc).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/provider/src/alloy/entry_point/v0_6.rs 0.00% 4 Missing ⚠️
crates/rpc/src/types/v0_7.rs 0.00% 4 Missing ⚠️
crates/rpc/src/types/v0_6.rs 33.33% 2 Missing ⚠️
crates/sim/src/estimation/estimate_call_gas.rs 0.00% 2 Missing ⚠️
crates/types/src/user_operation/v0_7.rs 33.33% 2 Missing ⚠️
crates/utils/src/authorization_utils.rs 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
crates/sim/src/estimation/v0_6.rs 95.08% <100.00%> (ø)
crates/sim/src/estimation/v0_7.rs 81.33% <100.00%> (ø)
crates/types/src/user_operation/v0_6.rs 89.30% <100.00%> (ø)
crates/rpc/src/types/v0_6.rs 26.22% <33.33%> (ø)
crates/sim/src/estimation/estimate_call_gas.rs 86.66% <0.00%> (ø)
crates/types/src/user_operation/v0_7.rs 63.35% <33.33%> (ø)
crates/utils/src/authorization_utils.rs 0.00% <0.00%> (ø)
crates/provider/src/alloy/entry_point/v0_6.rs 0.00% <0.00%> (ø)
crates/rpc/src/types/v0_7.rs 0.00% <0.00%> (ø)
Flag Coverage Δ
unit-tests 59.08% <36.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <ø> (ø)
builder 65.53% <ø> (ø)
dev ∅ <ø> (∅)
pool 66.98% <ø> (ø)
provider 19.41% <0.00%> (ø)
rpc 26.43% <14.28%> (ø)
sim 77.07% <60.00%> (ø)
tasks ∅ <ø> (∅)
types 66.52% <71.42%> (ø)
utils 32.43% <0.00%> (ø)

@@ -38,7 +38,7 @@ pub(crate) struct RpcUserOperation {
max_priority_fee_per_gas: U128,
paymaster_and_data: Bytes,
signature: Bytes,
eip7702_auth: Option<RpcEip7702Auth>,
eip7702auth: Option<RpcEip7702Auth>,
Copy link
Collaborator

@dancoombs dancoombs Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you just do this with serde(rename = "eip7702auth") instead of changing this everywhere?

@andysim3d andysim3d closed this Feb 6, 2025
@andysim3d
Copy link
Collaborator Author

after sync with EF, eip7702Auth is the correct annotation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants