Fix label check and add test #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanfkeepers
approved these changes
Apr 29, 2024
| @@ -118,7 +118,10 @@ func (err *Err) HasLabel(label string) bool { | |||
| return false | |||
| } | |||
|
|
|||
| if _, ok := err.labels[label]; ok { | |||
| // Check all labels in the error and it's stack since the stack isn't | |||
There was a problem hiding this comment.
Suggested change
| // Check all labels in the error and it's stack since the stack isn't | |
| // Check all labels in the error and its stack since the stack isn't |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation was originally only comparing against the labels in the top-level error. Therefore, if the label existed in one of the stacked errors it wouldn't be found if > 1 error was passed to
clues.Stack()but would be reported byclues.Labels()