Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the error trace #51

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Improve the error trace #51

merged 1 commit into from
Jul 16, 2024

Conversation

ryanfkeepers
Copy link
Contributor

instead of printing out the absolute Path for each error (which is a bit overkill in most situations), instead write the func name, and the parentdir + file:line where the error was generated or wrapped.

@ryanfkeepers ryanfkeepers requested review from ashmrtn and meain July 15, 2024 23:15
@ryanfkeepers ryanfkeepers self-assigned this Jul 15, 2024
Copy link
Member

@meain meain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parent should be good enough.

Base automatically changed from cleanup-2 to main July 16, 2024 23:48
instead of printing out the absolute Path for each error (which is a bit
overkill in most situations), instead write the func name, and the
parentdir + file:line where the error was generated or wrapped.
@ryanfkeepers ryanfkeepers merged commit 8889475 into main Jul 16, 2024
1 check passed
@ryanfkeepers ryanfkeepers deleted the update-err-trace branch July 16, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants