add witnesses #53
add witnesses #53
Conversation
witnesses add a targeted producer/consumer system to clues that allow downstream producers to relay data back up to upstream consumer contexts. They're not generally useful, but in certain cases where it becomes difficult to maintain delivery and receipt of clues otherwise they become a sort of necessary evil.
clues.go
Outdated
| // Relay adds all key-value pairs to the provided witness. The witness will | ||
| // record those values to the dataNode in which it was created. All relayed | ||
| // values are namespaced to the owning witness. | ||
| func Relay( |
There was a problem hiding this comment.
Not my favorite name. I'm open to suggestions. Preferably puns about a detective getting clues from a witness.
clues.go
Outdated
| // witness | ||
| // --------------------------------------------------------------------------- | ||
|
|
||
| // AddWitness adds a witness with a given name to the contex. The caller can |
There was a problem hiding this comment.
nit: without knowing what a witness is (and having no documentation on an exported Witness type, which itself is fine as it fits into the larger project architecture), having this described as adding a witness to something seems unhelpful
| // AddWitness adds a witness with a given name to the contex. The caller can | |
| // AddWitness adds a witness with a given name to the context. The caller can |
There was a problem hiding this comment.
check, will update.
datanode.go
Outdated
| return &dataNode{ | ||
| parent: dn, | ||
| labelCounter: dn.labelCounter, | ||
| witnesses: maps.Clone(dn.witnesses), |
There was a problem hiding this comment.
you may want to test this on different machine architectures. IIRC, I was having trouble with this function returning nil if the input was nil on Mac, which would eventually lead to NPEs when I tried to assign to the map
There was a problem hiding this comment.
good call, thank you
| "one": 1, | ||
| }, true) | ||
|
|
||
| mapEquals(t, ctxWithBob, msa{ |
There was a problem hiding this comment.
nit: could you please also make sure that the first two contexts with witnesses aren't changed?
witnesses add a targeted producer/consumer system to clues that allow downstream producers to relay data back up to upstream consumer contexts. They're not generally useful, but in certain cases where it becomes difficult to maintain delivery and receipt of clues otherwise they become a sort of necessary evil.