fix up otel init #73
Merged
fix up otel init #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanfkeepers
force-pushed
the
tester-framework
branch
from
7f1e7af to
ef4058e
Compare
ryanfkeepers
force-pushed
the
otel-metrics
branch
2 times, most recently
from
df60632 to
59102b6
Compare
pandeyabs
reviewed
Dec 3, 2024
internal/node/otel.go
Outdated
| conn *grpc.ClientConn, | ||
| server *resource.Resource, | ||
| ) (*sdkTrace.TracerProvider, error) { | ||
| if ctx != nil { |
There was a problem hiding this comment.
Few questions:
- What's the reasoning behind the 5 sec timeout?
- If the caller supplies a nil ctx, we'll fail to apply the 5 sec timeout to the request. That means request can run indefinitely. Instead, would it be better to return an error if ctx is nil?
There was a problem hiding this comment.
1/ I think it's to avoid hanging on the connection request. I think it's unnecessary in most cases, but also a common recommend in example code.
2/ good point. I don't think an error is correct, but I can indeed return.
ryanfkeepers
force-pushed
the
tester-framework
branch
from
ef4058e to
8cc6a85
Compare
Otel initialization is still somewhat hacky, but we're moving towards a cleaner implementation This change introduces the metrics (aka, meter) producer, and moves all producers (trace, log, metrics) into their own constructor funcs. Next PR will use this provider to implement a metrics api.
ryanfkeepers
force-pushed
the
otel-metrics
branch
from
59102b6 to
3e1edf0
Compare
pandeyabs
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otel initialization is still somewhat hacky, but we're moving towards a cleaner implementation This change introduces the metrics (aka, meter) producer, and moves all producers (trace, log, metrics) into their own constructor funcs.
Next PR will use this provider to implement a metrics api.