introduce ctats subpackage for metrics #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanfkeepers
force-pushed
the
otel-metrics
branch
2 times, most recently
from
df60632 to
59102b6
Compare
ryanfkeepers
force-pushed
the
otel-metrics-2
branch
from
a66efaa to
1515bdb
Compare
pandeyabs
approved these changes
Dec 3, 2024
| @@ -0,0 +1,144 @@ | |||
| package ctats | |||
There was a problem hiding this comment.
how about cstats instead of ctats? Rolls off the tongue easier.
There was a problem hiding this comment.
honestly I don't particularly like any of these. But for the life of me I haven't been able to come up with something better.
There was a problem hiding this comment.
I am okay with ctats too. Not worth worrying so much, we'll get used to it.
There was a problem hiding this comment.
no, no, what I mean is that I'd love to change the name. cstats is probably better, yes. I just wish there were a clearly perfect name.
ryanfkeepers
force-pushed
the
otel-metrics
branch
from
59102b6 to
3e1edf0
Compare
ctats (yes, pronounced "stats"; what, do you have a better name? Please, please tell me if you do...) is the OTEL metrics wrapper for clues. It seeks to reduce the current metrics interface into two basic steps: 1/ recording metrics. 2/ optional pre-registration of data-points to record. Most of the API is designed towards simplification of the OTEL interface into something that's approachable for generic development. This introduction leaves a few things to the side for later development: - unit testing (I should have this in place before the PR is complete) - multi-thread environment safety - maybe auto-initialization of system runtime metrics (cpu, memory, gc, etc)
ryanfkeepers
force-pushed
the
otel-metrics-2
branch
from
1515bdb to
72b7e4c
Compare
add unit tests for the ctats package. Found a bug along the way where we weren't adding entries into the map for ad-hoc counter declarations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ctats (yes, pronounced "stats"; what, do you have a better name? Please, please tell me if you do...) is the OTEL metrics wrapper for clues. It seeks to reduce the current metrics interface into two basic steps: 1/ recording metrics. 2/ optional pre-registration of data-points to record.
Most of the API is designed towards simplification of the OTEL interface into something that's approachable for generic development. This introduction leaves a few things to the side for later development: