Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Commit

Permalink
Pin vale and markdownlint-cli to current versions
Browse files Browse the repository at this point in the history
  • Loading branch information
meain committed Oct 7, 2022
1 parent 1b68789 commit 1ae0698
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -90,18 +90,16 @@ jobs:
environment: Testing
runs-on: ubuntu-latest
if: startsWith(github.ref, 'refs/tags/') || github.ref == 'refs/heads/release-ci' || needs.precheck.outputs.docfileschanged == 'true'
defaults:
run:
working-directory: docs

steps:
- uses: actions/checkout@v3

- name: Install dependencies for docs lint
run: |
sudo snap install --edge vale
npm install -g markdownlint-cli
vale --version && markdownlint --version
wget https://github.com/errata-ai/vale/releases/download/v2.20.2/vale_2.20.2_Linux_64-bit.tar.gz

This comment has been minimized.

Copy link
@ntolia

ntolia Oct 7, 2022

Contributor

How are we going to ensure this doesn't diverge from what we have in the docs Dockerfile?

This comment has been minimized.

Copy link
@meain

meain Oct 7, 2022

Author Member

As of now we will have to manually update them in both places. We could probably add this as a make step and use that in the Dockerfile as that too is just installing it by downloading releases.

This comment has been minimized.

Copy link
@meain

meain Oct 7, 2022

Author Member

I'll add a note in both places as of now. I guess we should be able to technically run the Dockerfile in the CI, but didn't do it that way as none of the other CI jobs that existed was using docker.

This comment has been minimized.

Copy link
@ntolia

ntolia Oct 7, 2022

Contributor

Yes, let's add a note in two places for now and we can look into this later.

mkdir bin && tar -xvzf vale_2.20.2_Linux_64-bit.tar.gz -C bin
echo "$PWD/bin" >> $GITHUB_PATH
npm i -g [email protected]
- uses: actions/download-artifact@master
name: Download cli docs from build step
Expand All @@ -111,7 +109,7 @@ jobs:

- name: Run docs lint
run: |
make -o genclidocs check
cd docs && make -o genclidocs check
# ----------------------------------------------------------------------------------------------------
# --- Integration and Unit Testing -------------------------------------------------------------------
Expand Down

0 comments on commit 1ae0698

Please sign in to comment.