-
Notifications
You must be signed in to change notification settings - Fork 45
Corso release version management #29
Comments
I currently have a PR at #1104 for this following the discussion on #1088 (comment) . As of now, the version shows up as the following:
Let me know if we should change the formats or have support for multiple formations like the package mentioned. |
#1104 was merged with the above format, let me know if it should be different. If not, we can close this issue. |
@ryanfkeepers @vkamra Let me know if the format should be changed. |
Do we want the tagged version to contain the SHA? In other places I've seen the following format used, and I personally found likeable:
Having a stable semver should be considered an equal identifier to the hash it represents, so both in the same version tag feels a little redundant. |
The suggestion of having both version and tag came from @vkamra in #1088 (comment) . I think it makes sense to have just the |
Let's remove the hash from released version |
Sounds good. I'll change the version to just the tag in case of release and keep the format for unreleased. |
## Description Adds the new CORSO_VERSION env needed to build docs in CI. ![2022-10-19-16-02-13](https://user-images.githubusercontent.com/14259816/196668301-cb5ad90c-4735-4132-b3ea-764d30948a62.png) ## Type of change <!--- Please check the type of change your PR introduces: ---> - [ ] 🌻 Feature - [ ] 🐛 Bugfix - [x] 🗺️ Documentation - [ ] 🤖 Test - [x] 💻 CI/Deployment - [ ] 🐹 Trivial/Minor ## Issue(s) <!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. --> * fixes #29 * #1205 ## Test Plan <!-- How will this be tested prior to merging.--> - [x] 💪 Manual - [ ] ⚡ Unit test - [ ] 💚 E2E
|
## Description Version reported for binaries inside docker images was incorrect. This fixes it and sets it to follow #29 ## Type of change <!--- Please check the type of change your PR introduces: ---> - [ ] 🌻 Feature - [ ] 🐛 Bugfix - [ ] 🗺️ Documentation - [ ] 🤖 Test - [x] 💻 CI/Deployment - [ ] 🐹 Trivial/Minor ## Issue(s) <!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. --> * #<issue> ## Test Plan <!-- How will this be tested prior to merging.--> - [x] 💪 Manual - [ ] ⚡ Unit test - [ ] 💚 E2E
Corso needs to track release versions, and provide those version details with the
corso --version
command. Whatever we use for versioning should work with https://goreleaser.com/.Possible packages:
The text was updated successfully, but these errors were encountered: