Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Corso release version management #29

Closed
ryanfkeepers opened this issue May 9, 2022 · 9 comments · Fixed by #1215
Closed

Corso release version management #29

ryanfkeepers opened this issue May 9, 2022 · 9 comments · Fixed by #1215
Assignees
Labels
enhancement New feature or request

Comments

@ryanfkeepers
Copy link
Contributor

Corso needs to track release versions, and provide those version details with the corso --version command. Whatever we use for versioning should work with https://goreleaser.com/.

Possible packages:

@ryanfkeepers ryanfkeepers added the enhancement New feature or request label May 9, 2022
@meain
Copy link
Member

meain commented Oct 13, 2022

I currently have a PR at #1104 for this following the discussion on #1088 (comment) . As of now, the version shows up as the following:

With tag:    v0.0.0-ceaf04c9
Without tag: unreleased-ceaf04c9

Let me know if we should change the formats or have support for multiple formations like the package mentioned.

@meain
Copy link
Member

meain commented Oct 14, 2022

#1104 was merged with the above format, let me know if it should be different. If not, we can close this issue.

@meain
Copy link
Member

meain commented Oct 18, 2022

@ryanfkeepers @vkamra Let me know if the format should be changed.

@ryanfkeepers
Copy link
Contributor Author

Do we want the tagged version to contain the SHA? In other places I've seen the following format used, and I personally found likeable:

  • vM.m.p (ex: v1.2.3) for stable releases.
  • vM.m.p-hash (ex: v1.2.3-ceaf04c9) for unreleased commits ahead of a stable release.

Having a stable semver should be considered an equal identifier to the hash it represents, so both in the same version tag feels a little redundant.

@meain
Copy link
Member

meain commented Oct 19, 2022

The suggestion of having both version and tag came from @vkamra in #1088 (comment) . I think it makes sense to have just the v*.*.* for releases. Having the previous tag for unreleased sounds useful.

@vkamra
Copy link
Contributor

vkamra commented Oct 19, 2022

Let's remove the hash from released version

@meain
Copy link
Member

meain commented Oct 19, 2022

Let's remove the hash from released version

Sounds good. I'll change the version to just the tag in case of release and keep the format for unreleased.

@ryanfkeepers
Copy link
Contributor Author

@meain @vkamra What's the possibility of adding a rolling or latest tag for unstable releases? Hashes are great, but difficult to script around. I'd be much more apt to test against the docker image if I can write myself an quick shim for things like rolling pull or rolling <corso commands>  

aviator-app bot pushed a commit that referenced this issue Oct 20, 2022
## Description

Adds the new CORSO_VERSION env needed to build docs in CI.

![2022-10-19-16-02-13](https://user-images.githubusercontent.com/14259816/196668301-cb5ad90c-4735-4132-b3ea-764d30948a62.png)

## Type of change

<!--- Please check the type of change your PR introduces: --->
- [ ] 🌻 Feature
- [ ] 🐛 Bugfix
- [x] 🗺️ Documentation
- [ ] 🤖 Test
- [x] 💻 CI/Deployment
- [ ] 🐹 Trivial/Minor

## Issue(s)

<!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. -->
* fixes #29
* #1205

## Test Plan

<!-- How will this be tested prior to merging.-->
- [x] 💪 Manual
- [ ] ⚡ Unit test
- [ ] 💚 E2E
@vkamra
Copy link
Contributor

vkamra commented Oct 20, 2022

@meain @vkamra What's the possibility of adding a rolling or latest tag for unstable releases? Hashes are great, but difficult to script around. I'd be much more apt to test against the docker image if I can write myself an quick shim for things like rolling pull or rolling <corso commands>

latest is used for the release builds. Let's use nightly to tag the latest image created off main.

aviator-app bot pushed a commit that referenced this issue Oct 29, 2022
## Description

Version reported for binaries inside docker images was incorrect. This fixes it and sets it to follow #29

## Type of change

<!--- Please check the type of change your PR introduces: --->
- [ ] 🌻 Feature
- [ ] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [ ] 🤖 Test
- [x] 💻 CI/Deployment
- [ ] 🐹 Trivial/Minor

## Issue(s)

<!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. -->
* #<issue>

## Test Plan

<!-- How will this be tested prior to merging.-->
- [x] 💪 Manual
- [ ] ⚡ Unit test
- [ ] 💚 E2E
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants