Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Fix version string for binaries inside docker images #1323

Merged
merged 3 commits into from
Oct 29, 2022
Merged

Fix version string for binaries inside docker images #1323

merged 3 commits into from
Oct 29, 2022

Conversation

meain
Copy link
Member

@meain meain commented Oct 25, 2022 •
edited
Loading

Description

Version reported for binaries inside docker images was incorrect. This fixes it and sets it to follow #29

Type of change

  • 🌻 Feature
  • 🐛 Bugfix
  • 🗺️ Documentation
  • 🤖 Test
  • 💻 CI/Deployment
  • 🐹 Trivial/Minor

Issue(s)

  • #

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@CLAassistant
Copy link

CLAassistant commented Oct 25, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@meain meain temporarily deployed to Testing October 25, 2022 12:00 Inactive
@meain meain temporarily deployed to Testing October 25, 2022 12:00 Inactive
@meain meain temporarily deployed to Testing October 25, 2022 12:00 Inactive
@meain meain temporarily deployed to Testing October 25, 2022 12:00 Inactive
@meain meain temporarily deployed to Testing October 25, 2022 12:01 Inactive
@meain meain self-assigned this Oct 25, 2022
@meain meain requested review from vkamra and gmatev October 25, 2022 12:01
@aviator-app
Copy link
Contributor

aviator-app bot commented Oct 25, 2022 •
edited
Loading

Aviator status

Aviator will automatically update this comment as the status of the PR changes.

This PR was merged using Aviator.

@meain meain temporarily deployed to Testing October 25, 2022 12:08 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing October 28, 2022 20:55 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing October 28, 2022 20:55 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing October 28, 2022 20:56 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing October 28, 2022 20:56 Inactive
@aviator-app aviator-app bot added the blocked Upstream item prevents completion label Oct 28, 2022
@aviator-app aviator-app bot temporarily deployed to Testing October 29, 2022 03:06 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing October 29, 2022 03:06 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing October 29, 2022 03:06 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing October 29, 2022 03:06 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing October 29, 2022 03:06 Inactive
@aviator-app aviator-app bot removed the blocked Upstream item prevents completion label Oct 29, 2022
@aviator-app aviator-app bot temporarily deployed to Testing October 29, 2022 03:21 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing October 29, 2022 03:21 Inactive
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@aviator-app aviator-app bot temporarily deployed to Testing October 29, 2022 03:22 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing October 29, 2022 03:22 Inactive
@aviator-app aviator-app bot added the blocked Upstream item prevents completion label Oct 29, 2022
@aviator-app aviator-app bot temporarily deployed to Testing October 29, 2022 03:57 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing October 29, 2022 03:57 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing October 29, 2022 03:57 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing October 29, 2022 03:57 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing October 29, 2022 03:57 Inactive
@aviator-app aviator-app bot removed the blocked Upstream item prevents completion label Oct 29, 2022
@aviator-app aviator-app bot temporarily deployed to Testing October 29, 2022 04:13 Inactive
@aviator-app aviator-app bot merged commit e4eaf44 into main Oct 29, 2022
@aviator-app aviator-app bot deleted the docker-binary-version branch October 29, 2022 04:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vkamra vkamra vkamra approved these changes

@gmatev gmatev Awaiting requested review from gmatev

Assignees

@meain meain

Labels
mergequeue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meain @CLAassistant @vkamra