Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

get details working (and other cleanup) #5116

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

ryanfkeepers
Copy link
Contributor

details wasn't properly listing backed up items. This fixes the details display, and contains some code clean-up that occurred along the way.


Does this PR need a docs update or release note?

  • ⛔ No

Type of change

  • 🐛 Bugfix

Issue(s)

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@ryanfkeepers ryanfkeepers added bug Something isn't working backup chats 1:1 chats within teams labels Jan 24, 2024
@ryanfkeepers ryanfkeepers self-assigned this Jan 24, 2024
Copy link
Contributor

aviator-app bot commented Jan 24, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@ryanfkeepers ryanfkeepers force-pushed the 5063-chats-backup-v0-1 branch from 4cba773 to 316e5f0 Compare January 30, 2024 20:15
details wasn't properly listing backed up items.  This fixes
the details display, and contains some code clean-up that occurred
along the way.
lazily fetch the chat members and add them to the chat during backup
item downloads.
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ryanfkeepers ryanfkeepers merged commit 0efe25b into 5063-chats-backup-v0-1 Feb 15, 2024
11 of 15 checks passed
@ryanfkeepers ryanfkeepers deleted the 5063-chats-backup-v0-2 branch February 15, 2024 21:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backup bug Something isn't working chats 1:1 chats within teams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants