This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
add export support in teamschats collections processor #5125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
introduces the Chats service and Chats category
standard boilerplate additions, largely copy-paste and renamed from other files.
standard graph api boilerplate.
seems like a lot of code, but this is 95% boilerplate additions copied from other similar collections packages. Some noteworthy differences: * teamsChats does not handle metadata, so all metadata, delta, and previous path handling was removed * teamsChats does not produce tombstones * chats are never deleted, so no "removed" items are tracked * all chats gets stored at the prefix root, so no "containers" are iterated, and therefore only one collection is ever produced. This means that, overall, the boilerplate here is much reduced compared to boilerplate in similar packages.
tests will arrive in a later PR
All code is copied and amended from existing cli boilerplate.
Some necessary changes to get a green backup creation from the cli.
once we're past kopia assits, the chat can download all of its messages and store them in the body uploded to kopia.
details wasn't properly listing backed up items. This fixes the details display, and contains some code clean-up that occurred along the way.
lazily fetch the chat members and add them to the chat during backup item downloads.
ryanfkeepers
added
export
Current Aviator status
This PR was closed without merging. If you still want to merge this PR, re-open it.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
ryanfkeepers
had a problem deploying
to
Testing
GitHub Actions
Failure
ryanfkeepers
had a problem deploying
to
Testing
GitHub Actions
Failure
ryanfkeepers
had a problem deploying
to
Testing
GitHub Actions
Failure
ryanfkeepers
had a problem deploying
to
Testing
GitHub Actions
Failure
ryanfkeepers
had a problem deploying
to
Testing
GitHub Actions
Failure
HiteshRepo
reviewed
Jan 26, 2024
Comment on lines
+194
to
+197
| var isDeleted bool | ||
|
|
||
| deletedAt, ok := ptr.ValOK(item.GetDeletedDateTime()) | ||
| isDeleted = ok && deletedAt.After(time.Time{}) |
There was a problem hiding this comment.
Suggested change
| var isDeleted bool | |
| deletedAt, ok := ptr.ValOK(item.GetDeletedDateTime()) | |
| isDeleted = ok && deletedAt.After(time.Time{}) | |
| deletedAt, ok := ptr.ValOK(item.GetDeletedDateTime()) | |
| isDeleted := ok && deletedAt.After(time.Time{}) |
HiteshRepo
approved these changes
Jan 26, 2024
ryanfkeepers
force-pushed
the
5036-chats-backup-v0-3
branch
from
3912a64 to
480e3a8
Compare
Base automatically changed from
5036-chats-backup-v0-3
to
5063-chats-backup-v0-2
February 15, 2024 21:25
Base automatically changed from
5063-chats-backup-v0-2
to
5063-chats-backup-v0-1
February 15, 2024 21:32
more boilerplate adaptation
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more boilerplate adaptation
Does this PR need a docs update or release note?
Type of change
Issue(s)
Test Plan