Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Skip ms auth checks for gock client #5163

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Skip ms auth checks for gock client #5163

merged 1 commit into from
Jan 30, 2024

Conversation

ashmrtn
Copy link
Contributor

@ashmrtn ashmrtn commented Jan 29, 2024

Disable sending requests to microsoft servers to get API tokens when
using the gock client. This is accomplished by passing in a mock that
always returns no error for auth requests.

This PR does not go through and make existing tests using gock unit
tests instead of integration tests. That will need to be done
separately


Does this PR need a docs update or release note?

  • ✅ Yes, it's included
  • 🕐 Yes, but in a later PR
  • ⛔ No

Type of change

  • 🌻 Feature
  • 🐛 Bugfix
  • 🗺️ Documentation
  • 🤖 Supportability/Tests
  • 💻 CI/Deployment
  • 🧹 Tech Debt/Cleanup

Issue(s)

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

Disable sending requests to microsoft servers to get API tokens when
using the gock client. This is accomplished by passing in a mock that
always returns no error for auth requests.
@ashmrtn ashmrtn added tests supportability graph api for changes related to communicating directly with the graph rest api labels Jan 29, 2024
@ashmrtn ashmrtn requested review from meain and ryanfkeepers January 29, 2024 23:50
@ashmrtn ashmrtn self-assigned this Jan 29, 2024
Copy link
Contributor

aviator-app bot commented Jan 29, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.


See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@aviator-app aviator-app bot merged commit d2f1bbb into main Jan 30, 2024
24 checks passed
@aviator-app aviator-app bot deleted the 5124-no-gock-ms-auth branch January 30, 2024 02:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
graph api for changes related to communicating directly with the graph rest api mergequeue supportability tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants