Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

move M365 creds rotation logic to code #5182

Draft
wants to merge 1 commit into
base: 5080-enable-cache
Choose a base branch
from

Conversation

HiteshRepo
Copy link
Contributor

moves M365 creds rotation logic to code

Does this PR need a docs update or release note?

  • βœ… Yes, it's included
  • πŸ• Yes, but in a later PR
  • β›” No

Type of change

  • 🌻 Feature
  • πŸ› Bugfix
  • πŸ—ΊοΈ Documentation
  • πŸ€– Supportability/Tests
  • πŸ’» CI/Deployment
  • 🧹 Tech Debt/Cleanup

Issue(s)

#5080

Test Plan

  • πŸ’ͺ Manual
  • ⚑ Unit test
  • πŸ’š E2E

Copy link
Contributor

aviator-app bot commented Feb 5, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This pull request is currently open (not queued).

How to merge

To merge this PR, comment /aviator merge or add the mergequeue label.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@HiteshRepo HiteshRepo marked this pull request as draft February 5, 2024 15:28
Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ryanfkeepers
Copy link
Contributor

This is not a rotation, it's a randomization. We currently provide consistency between runs (theoretically) by binding each run to an account determined by the run ID, here: https://github.com/alcionai/corso/blob/main/.github/workflows/accSelector.yaml

Are we sure we want to drop this behavior to use a randomizer instead?

@HiteshRepo
Copy link
Contributor Author

This is not a rotation, it's a randomization. We currently provide consistency between runs (theoretically) by binding each run to an account determined by the run ID, here: https://github.com/alcionai/corso/blob/main/.github/workflows/accSelector.yaml

Are we sure we want to drop this behavior to use a randomizer instead?

No @ryanfkeepers I am not sure about the solution. The real intention is to not change environment variables across test runs. Because changing env-vars are leading to tests not being cached

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants