This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 45
Add CI for linting docs #998
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kudos, SonarCloud Quality Gate passed! |
I've rebased the PR against current master to fix conflicts and squashed the intermediate commits. Let me know if there is anything else needed in the PR. |
ryanfkeepers
approved these changes
Oct 4, 2022
I've reworked and combined all of this logic into a single ci jobs in #1052. Since this is not merged, closing this in favor of that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new CI job to lint docs. As of now, the cli docs are only linted if there is change in the src files (ref). This PR also removes the CI action to automatically generate docs and commits to codebase.
It does not include the push to s3, I'll pick that up in a follow up PR along for #571 .
Type of change
Issue(s)
make check
) to CI/GitHub Actions #69Test Plan