Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support sign unsigned tx #13

Merged
merged 85 commits into from
Jul 17, 2024
Merged

Support sign unsigned tx #13

merged 85 commits into from
Jul 17, 2024

Conversation

Lbqds
Copy link
Member

@Lbqds Lbqds commented Jan 26, 2024 •
edited
Loading

Currently the ledger wallet can decode all transaction types, we use this tool to generate the instr decoder. I have tested the following scenarios:

  1. Transfer ALPH and tokens
  2. Transfer to multi-sig address
  3. Transfer to p2sh address
  4. Create a token pool, add liquidity, and swap
  5. Bridge

TODO:

  1. Add sign message instr

Lbqds added 30 commits January 16, 2024 09:48
@Lbqds
Update ledger rust sdk
0b5ec85
@Lbqds
Update ledger app builder
544615e
@Lbqds
Add nanox artifacts to .gitignore
897dde1
@Lbqds
Update speculos to 0.5.0
f9a4b8e
@Lbqds
Cargo fmt & cargo clippy
90c4fc9
@Lbqds
Remove unused code
e953d76
@Lbqds
Add decoder
90b0a34
@Lbqds
Add unsigned tx decoder
279fd7b
@Lbqds
Add more tests
2067209
@Lbqds
Add blind signing setting
e9914dd
@Lbqds
Send unsigned tx to ledger wallet
266470e
@Lbqds
Add error codes
0ec9716
@Lbqds
Add blake2b hasher
9073269
@Lbqds
Add sign tx instr
9cd4d6d
@Lbqds
Convert number to string
4b2a9df
@Lbqds
Display tx details
66a36a2
@Lbqds
Display inputs and outputs one by one
4ff2ef1
@Lbqds
Improve decode unsigned tx
1616d68
@Lbqds
Rename
ed14d09
@Lbqds
Update artifacts
105874d
@Lbqds
Cargo fmt
706a499
@Lbqds
Support script tx
d92e272
@Lbqds
Warning if blind signing is not enabled when signing script tx
9c812e4
@Lbqds
Replace usize with u16
9de4689
@Lbqds
Display addresses
57a9f61
@Lbqds
Improve sign tx ui
c909911
@Lbqds
Remove sign hash instr
6186f32
@Lbqds
Reduce duplicate codes using macros
7b1317a
@Lbqds
Update artifacts
43f02e7
@Lbqds
Minor fix
6c1bcc3
@Lbqds Lbqds force-pushed the support-sign-unsigned-tx branch from 33c7a35 to 8587574 Compare February 27, 2024 00:50
h0ngcha0
h0ngcha0 reviewed Jul 8, 2024
View reviewed changes
utils/src/buffer.rs Show resolved Hide resolved
utils/src/temp_data.rs Show resolved Hide resolved
utils/src/types/avector.rs Show resolved Hide resolved
utils/src/types/avector.rs Outdated Show resolved Hide resolved
utils/src/types/byte_string.rs Show resolved Hide resolved
utils/src/types/lockup_script.rs Outdated Show resolved Hide resolved
utils/src/types/lockup_script.rs Outdated Show resolved Hide resolved
utils/src/types/hint.rs Outdated Show resolved Hide resolved
utils/src/types/u256.rs Outdated Show resolved Hide resolved
utils/src/types/unsigned_tx.rs Show resolved Hide resolved
polarker
polarker reviewed Jul 8, 2024
View reviewed changes
app/src/nvm_buffer.rs Outdated Show resolved Hide resolved
app/src/sign_tx_context.rs Outdated Show resolved Hide resolved
app/src/sign_tx_context.rs Outdated Show resolved Hide resolved
app/src/tx_reviewer.rs Outdated Show resolved Hide resolved
app/src/error_code.rs Outdated Show resolved Hide resolved
app/src/sign_tx_context.rs Outdated Show resolved Hide resolved
app/src/tx_reviewer.rs Show resolved Hide resolved
app/src/tx_reviewer.rs Outdated Show resolved Hide resolved
app/src/tx_reviewer.rs Outdated Show resolved Hide resolved
app/src/tx_reviewer.rs Outdated Show resolved Hide resolved
polarker
polarker reviewed Jul 17, 2024
View reviewed changes
utils/src/buffer.rs Show resolved Hide resolved
utils/src/buffer.rs Show resolved Hide resolved
utils/src/buffer.rs Show resolved Hide resolved
utils/src/base58.rs Show resolved Hide resolved
utils/src/temp_data.rs Show resolved Hide resolved
doc/apdu.md Show resolved Hide resolved
js/package.json Show resolved Hide resolved
js/src/index.ts Show resolved Hide resolved
utils/src/decode.rs Show resolved Hide resolved
polarker
polarker reviewed Jul 17, 2024
View reviewed changes
app/src/tx_reviewer.rs Show resolved Hide resolved
app/src/tx_reviewer.rs Show resolved Hide resolved
@polarker polarker merged commit 17b9d39 into master Jul 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h0ngcha0 h0ngcha0 h0ngcha0 left review comments

@polarker polarker polarker left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lbqds @polarker @h0ngcha0