Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nic Patterson Interview #16

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Conversation

reynn
Copy link

@reynn reynn commented Apr 26, 2024

Updates included in this PR:

  • Change from file based configuration to environment based configuration. Decided to use the minimal github.com/caarlos0/env library based on prior usage and 0 extra dependencies.
  • Add Dockerfiles for existing service and client. Parameterized the Go version that will build the binary and used multi-stage build to keep final image size small.
  • Added structured logging via the log/slog package available now in the Go standard library. Client uses the text handler and the Service uses the JSON handler.
  • Add Github Actions for an initial continuous integration pipeline. This could be expanded later to include building and publishing the Docker images to a remote registry.
  • Add Makefile with targets to build/test/run various components of the project.
  • Add authservice-go to handle client authentication and jwt validation.

@reynn reynn requested a review from alex-wzm as a code owner April 26, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant