Update modules with missing steps #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajot
reviewed
Aug 24, 2020
| @@ -66,7 +76,7 @@ import logging | |||
| import ask_sdk_core.utils as ask_utils | |||
| import os | |||
| from ask_sdk_s3.adapter import S3Adapter | |||
| s3_adapter = S3Adapter(bucket_name=os.environ["S3_PERSISTENCE_BUCKET"]) | |||
| s3_adapter = S3Adapter(bucket_name="NAME_OF_YOUR_BUCKET_HERE") | |||
There was a problem hiding this comment.
Why are we removing os.environ from here? That's how an Alexa Hosted skill references an S3 bucket created by Alexa Hosted.
There was a problem hiding this comment.
Using os.environ["my_bucket_name"] throws errors during testing. The log is not very descriptive but this is what it looks like.
ajot
reviewed
Aug 24, 2020
| @@ -8,7 +8,7 @@ | |||
| import ask_sdk_core.utils as ask_utils | |||
| import os | |||
| from ask_sdk_s3.adapter import S3Adapter | |||
| s3_adapter = S3Adapter(bucket_name=os.environ["S3_PERSISTENCE_BUCKET"]) | |||
| s3_adapter = S3Adapter(bucket_name="NAME_OF_YOUR_BUCKET_HERE") | |||
There was a problem hiding this comment.
Why are we removing os.environ from here? That's how an Alexa Hosted skill references an S3 bucket created by Alexa Hosted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
I worked through the tutorial and ended up debugging quite a few issues, so I updated the tutorial to contain missing steps that are required to get the skill working. I also did some markdown reformatting and added a few images to make the steps clearer.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.