Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libssh2-sys: use src instead .git as vendored indicator #241

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

catap
Copy link

@catap catap commented Feb 9, 2022

When someone vendored libssh-sys he may exclude .git folder.

When such things happened an attempt to build it may lead to error like: fatal: not a git repository (or any of the parent directories): .git.

When someone vendored `libssh-sys` he may exclude `.git` folder.

When such things happened an attempt to build it may lead to error like: `fatal: not a git repository (or any of the parent directories): .git`.
@demosdemon
Copy link
Contributor

This will resolve #288 once committed.

@yodaldevoid
Copy link
Collaborator

The error may be printed, but it should not stop compilation unless the vendored copy of libssh2 really hasn't been populated.

@kiripon
Copy link

kiripon commented Jul 29, 2024

Hi, @yodaldevoid .

I would like this PR to be merged too.

I build Rust using a different build system than cargo, which tracks and logs all file accesses made during the build to determine if a build needs to be rerun.
Unless this change is merged, it will be assumed that the build dependency is accessing .git/index, which will affect the build rerun decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants