Skip to content

Commit

Permalink
Remove pieces of code in common tests that skipped tests for removed …
Browse files Browse the repository at this point in the history
…environments.
  • Loading branch information
alexhernandezgarcia committed Mar 4, 2024
1 parent 2fbb792 commit 5104fd2
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions tests/gflownet/envs/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -169,11 +169,6 @@ def test__backward_actions_have_nonzero_forward_prob(
n_repeat = self.repeats[_get_current_method_name()]

for _ in range(n_repeat):
# Skip for certain environments until fixed:
skip_envs = ["Crystal", "LatticeParameters"]
if self.env.__class__.__name__ in skip_envs:
warnings.warn("Skipping test for this specific environment.")
return
states = _get_terminating_states(self.env, n_states)
if states is None:
warnings.warn("Skipping test because states are None.")
Expand Down Expand Up @@ -233,8 +228,6 @@ def test__sample_backwards_reaches_source(self, n_repeat=1, n_states=100):
def test__trajectories_are_reversible(self, n_repeat=1):
# Skip for certain environments until fixed:
skip_envs = [
"Crystal",
"LatticeParameters",
"Tree",
] # TODO: handle this using the count instead.
if self.env.__class__.__name__ in skip_envs:
Expand Down Expand Up @@ -522,9 +515,6 @@ def _get_current_method_name():


def _get_terminating_states(env, n):
# Hacky way of skipping the Crystal BW sampling test until fixed.
if env.__class__.__name__ == "Crystal":
return
if hasattr(env, "get_all_terminating_states"):
return env.get_all_terminating_states()
elif hasattr(env, "get_grid_terminating_states"):
Expand Down

0 comments on commit 5104fd2

Please sign in to comment.