Changes to main FL loss PR #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…simple enough to do in place
… state_flow inside gflownet
AlexandraVolokhova
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a suggestion of changes to the currently open PR about the new FL loss #253
There are three main changes:
get_parent_is_source()in theBatchclass because it is used only once and it is simple enough to do it in place.self.non_terminal_rewardsfrom both theGFlowNetAgentand theBatch, because they are barely used and the code is probably cleaner without it.forwardlooking.yamlconfig file inconfig/gflownet/to make the FL work like the other losses, and move thestate_flowconfig insideconfig/gflownettoo.